Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using template to set container image versions #79

Closed
MicaiahReid opened this issue Oct 9, 2023 · 1 comment
Closed

Consider using template to set container image versions #79

MicaiahReid opened this issue Oct 9, 2023 · 1 comment
Assignees
@MicaiahReid

Comments

@MicaiahReid
Copy link
Contributor

MicaiahReid commented Oct 9, 2023 •
edited by andresgalante
Loading

We might want to template this image, as well as any other image being used in other containers. Otherwise if we want/need to change the images being used, it'll require a new release. It's much easier if we're able to control this aspect through infra config, like an ENV variable we set in the devnet-api itself.

Originally posted by @CharlieC3 in #75 (comment)
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Oct 9, 2023
@MicaiahReid MicaiahReid mentioned this issue Oct 9, 2023
Merged
2 tasks
@MicaiahReid MicaiahReid moved this from 🆕 New to 📋 Backlog in DevTools Oct 9, 2023
@MicaiahReid MicaiahReid self-assigned this Oct 9, 2023
@MicaiahReid
Copy link
Contributor Author

Closing as things seem to be working fine. This could possibly make things a bit simpler in the code, but is not crucial.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in DevTools Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MicaiahReid MicaiahReid

Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MicaiahReid