Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: rename assets #69

Merged
merged 13 commits into from
Sep 25, 2023
Merged

breaking: rename assets #69

merged 13 commits into from
Sep 25, 2023

Conversation

MicaiahReid
Copy link
Contributor

@MicaiahReid MicaiahReid commented Sep 25, 2023 •
edited
Loading

Downstream pods are now renamed, so proxied requests have a different route.

  • stacks-node is now stacks-blockchain
  • stacks-api is now stacks-blockchain-api

Fixes #61

@MicaiahReid MicaiahReid changed the base branch from develop to prd-fixes September 25, 2023 14:18
@MicaiahReid MicaiahReid changed the base branch from prd-fixes to develop September 25, 2023 14:18
@MicaiahReid MicaiahReid changed the base branch from develop to prd-fixes September 25, 2023 14:18
@MicaiahReid MicaiahReid mentioned this pull request Sep 25, 2023
Closed
@MicaiahReid MicaiahReid changed the title Asset rename breaking: rename assets Sep 25, 2023
@MicaiahReid MicaiahReid changed the base branch from prd-fixes to develop September 25, 2023 14:20
CharlieC3
CharlieC3 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok. Will need to be tested in the dev environment to be sure.

@MicaiahReid MicaiahReid temporarily deployed to Development September 25, 2023 15:19 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@d4c2290). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #69   +/-   ##
==========================================
  Coverage           ?   78.71%           
==========================================
  Files              ?       11           
  Lines              ?     1062           
  Branches           ?        0           
==========================================
  Hits               ?      836           
  Misses             ?      226           
  Partials           ?        0

@MicaiahReid MicaiahReid merged commit cb57c32 into develop Sep 25, 2023
7 checks passed
@MicaiahReid MicaiahReid deleted the asset-rename branch September 25, 2023 18:31
@MicaiahReid MicaiahReid temporarily deployed to Staging September 25, 2023 18:47 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid mentioned this pull request Sep 25, 2023
Closed
@blockstack-devops
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieC3 CharlieC3 CharlieC3 approved these changes

Assignees
No one assigned
Labels
released
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MicaiahReid @blockstack-devops @CharlieC3