Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource name changes #62

Closed
CharlieC3 opened this issue Sep 21, 2023 · 1 comment
Closed

Resource name changes #62

CharlieC3 opened this issue Sep 21, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@CharlieC3
Copy link
Member

CharlieC3 commented Sep 21, 2023

For consistency with our other services, can we update some resource names? Here are some suggestions that would make us aligned with our other infra.

Pods

  • change stacks-api to stacks-blockchain-api
  • change stacks-node to stacks-blockchain

Containers

  • Exclude -container suffix where applicable
  • Update container names to match the repository/project they came from (e.g. stacks-api-container > stacks-blockchain-api, stacks-api-postgres > postgres, etc)

Services

  • Service names should match the pod they're routing traffic to (e.g. stacks-api-service would change to stacks-blockchain-api)

PVC

  • stacks-api-pvc should change to stacks-blockchain-api-pg

Configmap

  • Exclude -conf suffix where applicable
  • I think the namespace-conf CM can be replaced with a slight change in the bitcoind container.
    • If you add this to the env: section of the bitcoind container definition, you won't need this CM anymore.
    - name: NAMESPACE
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: metadata.namespace
    
  • Update stacks-api-conf to stacks-blockchain-api
  • Update stacks-api-postgres-conf to stacks-blockchain-api-pg
  • Update stacks-node-conf to stacks-blockchain
@CharlieC3 CharlieC3 added the enhancement New feature or request label Sep 21, 2023
@MicaiahReid MicaiahReid self-assigned this Sep 22, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Sep 22, 2023
@MicaiahReid MicaiahReid moved this from 🆕 New to 🏗 In Progress in DevTools Sep 22, 2023
@MicaiahReid MicaiahReid moved this from 🏗 In Progress to 👀 In Review in DevTools Sep 25, 2023
@MicaiahReid
Copy link
Contributor

Fixed by #69

@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in DevTools Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants