fix: pass selected provider when not persisting selection

.changeset/ninety-zebras-relax.md

@@ -0,0 +1,6 @@
+---
+'@stacks/connect-ui': patch
+'@stacks/connect': patch
+---
+
+Fix bug that would revert to undefined wallet popup behavior.

packages/connect-ui/src/components/modal/modal.tsx

@@ -1,5 +1,5 @@
 import { Component, Element, Prop, h } from '@stencil/core';
-import { WebBTCProvider } from '../../providers';
+import { WebBTCProvider, getProviderFromId } from '../../providers';
 import { setSelectedProviderId } from '../../session';
 import CloseIcon from './assets/close-icon.svg';
 import { getBrowser, getPlatform } from './utils';
@@ -23,7 +23,7 @@ export class Modal {
   handleSelectProvider(providerId: string) {
     if (this.persistSelection) setSelectedProviderId(providerId);
     this.modalEl.remove();
-    this.callback();
+    this.callback(getProviderFromId(providerId));
   }
 
   handleCloseModal() {

packages/connect-ui/src/providers.ts

@@ -48,9 +48,13 @@ export const getInstalledProviders = (defaultProviders: WebBTCProvider[] = []) =
     if (registeredProviders.find(rp => rp.id === dp.id)) return false;
 
     // check if default provider is installed (even if not registered)
-    const provider = dp.id.split('.').reduce((acc, part) => acc?.[part], window);
+    const provider = getProviderFromId(dp.id);
     return !!provider;
   });
 
   return registeredProviders.concat(additionalInstalledProviders);
 };
+
+export const getProviderFromId = (id: string | undefined) => {
+  return id?.split('.').reduce((acc, part) => acc?.[part], window);
+};

packages/connect/src/ui.ts

@@ -67,7 +67,7 @@ function wrapConnectCall<O extends ActionOptions>(
     element.defaultProviders = defaultProviders;
     element.installedProviders = installedProviders;
     element.persistSelection = persistSelection;
-    element.callback = () => action(o);
+    element.callback = (passedProvider: StacksProvider | undefined) => action(o, passedProvider);
 
     document.body.appendChild(element);
 

packages/connect/src/utils.ts

@@ -1,9 +1,7 @@
-import { getSelectedProviderId } from '@stacks/connect-ui';
+import { getSelectedProviderId, getProviderFromId } from '@stacks/connect-ui';
 
 export function getStacksProvider() {
-  const providerId = getSelectedProviderId();
-  const provider = providerId?.split('.').reduce((acc, part) => acc?.[part], window);
-
+  const provider = getProviderFromId(getSelectedProviderId());
   return provider || window.StacksProvider || window.BlockstackProvider;
 }