Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass selected provider when not persisting selection #351

Merged
merged 3 commits into from
Jan 4, 2024
Merged

fix: pass selected provider when not persisting selection #351

merged 3 commits into from
Jan 4, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Dec 21, 2023 •
edited by github-actions bot
Loading

This PR was published to npm with the alpha versions:

@janniks janniks requested a review from beguene December 21, 2023 12:45
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 31c0272

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@stacks/connect-ui Patch
@stacks/connect Patch
@stacks/connect-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 3:30pm
connect-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 3:30pm

@janniks janniks requested review from BLuEScioN and removed request for beguene December 21, 2023 12:45
@janniks janniks requested a review from He1DAr December 21, 2023 12:47
He1DAr
He1DAr approved these changes Jan 4, 2024
View reviewed changes
Copy link

@He1DAr He1DAr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉! left a couple of minor suggestions.

packages/connect-ui/src/providers.ts Show resolved Hide resolved
packages/connect-ui/src/providers.ts Outdated Show resolved Hide resolved
packages/connect/src/ui.ts Outdated Show resolved Hide resolved
@janniks janniks mentioned this pull request Jan 4, 2024
Open
@janniks janniks merged commit c475c32 into main Jan 4, 2024
8 checks passed
@janniks janniks deleted the fix/update-provider-passing branch January 4, 2024 15:41
@github-actions github-actions bot mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He1DAr He1DAr He1DAr approved these changes

@BLuEScioN BLuEScioN Awaiting requested review from BLuEScioN

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In the authentication modal clicking on Xverse opens Leather if both extensions are installed
2 participants
@janniks @He1DAr