fix: ensure proper prefix for tenant repositories in storage operations#1082
fix: ensure proper prefix for tenant repositories in storage operations#1082nerdeveloper wants to merge 2 commits intohelm:mainfrom
Conversation
|
@nerdeveloper Thank you for following this issue , I looked it before and totally forget this after a period XD . The implementation is LGTM , but I am a little confusing about the testing code , in my opinion , we do not need to mock the backend storage , we use the local storage as the backend provider by default , and the tests maybe should include the behavior changes about multi-tenant's depth server , or do I miss the some original information ? |
|
I am using the local‐filesystem backend (not a mock) inside the tests and added the behaviour change you mentioned (prefix isolation for multi-tenant depth). @scbizu, let me know |
|
Hi @nerdeveloper , I am looking back this issue , and find that the unit testing code maybe unnecessary for this case , because our test code using local as backend provider . And the local storage impl is correct for this case . To keep the behavior is the similar from every backend provider , I prefer to change the storage package and not the CM end , what do you think ? |
See: - helm/chartmuseum#1082 - helm/chartmuseum#794 Signed-off-by: scnace <scbizu@gmail.com>
|
I have created a PR in storage , @nerdeveloper can you help to check it ? |
See: - helm/chartmuseum#1082 - helm/chartmuseum#794 Signed-off-by: scnace <scbizu@gmail.com>
See: - helm/chartmuseum#1082 - helm/chartmuseum#794 Signed-off-by: scnace <scbizu@gmail.com>
See: - helm/chartmuseum#1082 - helm/chartmuseum#794 Signed-off-by: scnace <scbizu@gmail.com>
This PR fixes a critical tenant isolation bug in ChartMuseum:
Before the fix:
After the fix:
To make it super clear: