Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passkeys support: Rename Devise::Strategies::Authenticatable => PasswordAuthenticatable #5531

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Oct 20, 2022

  1. Rename Devise::Strategies::Authenticatable => PasswordAuthenticatable

    * To begin the process of refactoring Devise to support passkeys, we
    	need to decouple authentication from being specifically tied to
    	passwords.
    	* The first step is explicitly prefixing generically-named components
    		like `Authenticatable` with `Password`, since they concern password
    		authentication
    tcannonfodder committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    343ac49 View commit details
    Browse the repository at this point in the history
  2. Add Devise::Strategies::Authenticatable shim w/ deprecation warning

    * To maintain compatability with exisiting installations, we need the
    	`Devise::Strategies::Authenticatable` class.
    	* This re-adds the class in, subclassing from `PasswordAuthenticable`
    		and printing a deprecation warning
    tcannonfodder committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    6fbca11 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Configuration menu
    Copy the full SHA
    f577537 View commit details
    Browse the repository at this point in the history
  2. Rename DatabaseAuthenticatable=>DatabasePasswordAuthenticatable

    * To begin the process of refactoring Devise to support passkeys, we
    	need to decouple authentication from being specifically tied to
    	passwords.
    	* The first step is explicitly prefixing generically-named components
    		like `Authenticatable` with `Password`, since they concern password
    		authentication
    tcannonfodder committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    cf0afca View commit details
    Browse the repository at this point in the history
  3. Devise::Strategies::DatabaseAuthenticatable shim w/ warning

    * To maintain compatability with exisiting installations, we need the
    	`Devise::Strategies::DatabaseAuthenticatable` class.
    	* This re-adds the class in, subclassing from
    		`DatabasePasswordAuthenticable` and printing a deprecation warning
    tcannonfodder committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    ea157bb View commit details
    Browse the repository at this point in the history
  4. Rename Rememberable=>PasswordRememberable

    * To begin the process of refactoring Devise to support passkeys, we
    	need to decouple authentication from being specifically tied to
    	passwords.
    	* The first step is explicitly prefixing generically-named components
    		like `Authenticatable` with `Password`, since they concern password
    		authentication
    tcannonfodder committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    261db02 View commit details
    Browse the repository at this point in the history
  5. Add Devise::Strategies::Rememberable shim w/ deprecation warning

    * To maintain compatability with exisiting installations, we need the
    	`Devise::Strategies::Rememberable` class.
    	* This re-adds the class in, subclassing from `PasswordRememberable`
    		and printing a deprecation warning
    tcannonfodder committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    0cf0440 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #5 from tcannonfodder/2022-10-26-finish-prefixing-…

    …with-password
    
    2022 10 26 finish prefixing with password
    tcannonfodder authored Oct 27, 2022
    Configuration menu
    Copy the full SHA
    eeaadd6 View commit details
    Browse the repository at this point in the history