Passkeys support: Rename Devise::Strategies::Authenticatable => PasswordAuthenticatable #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* To begin the process of refactoring Devise to support passkeys, we need to decouple authentication from being specifically tied to passwords. * The first step is explicitly prefixing generically-named components like `Authenticatable` with `Password`, since they concern password authentication
* To maintain compatability with exisiting installations, we need the `Devise::Strategies::Authenticatable` class. * This re-adds the class in, subclassing from `PasswordAuthenticable` and printing a deprecation warning
* To begin the process of refactoring Devise to support passkeys, we need to decouple authentication from being specifically tied to passwords. * The first step is explicitly prefixing generically-named components like `Authenticatable` with `Password`, since they concern password authentication
* To maintain compatability with exisiting installations, we need the `Devise::Strategies::DatabaseAuthenticatable` class. * This re-adds the class in, subclassing from `DatabasePasswordAuthenticable` and printing a deprecation warning
* To begin the process of refactoring Devise to support passkeys, we need to decouple authentication from being specifically tied to passwords. * The first step is explicitly prefixing generically-named components like `Authenticatable` with `Password`, since they concern password authentication
* To maintain compatability with exisiting installations, we need the `Devise::Strategies::Rememberable` class. * This re-adds the class in, subclassing from `PasswordRememberable` and printing a deprecation warning
…with-password 2022 10 26 finish prefixing with password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename Devise::Strategies::Authenticatable => PasswordAuthenticatable
AuthenticatablewithPassword, since they concern password authenticationAdd Devise::Strategies::Authenticatable shim w/ deprecation warning
Devise::Strategies::Authenticatableclass.PasswordAuthenticableand printing a deprecation warning