Fix: missing allocated translation key #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
added
the
Require backport v1.3
torchiaf
approved these changes
Sep 19, 2024
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We changed storage title from "Reserved" to "Allocated" in https://github.com/harvester/dashboard/pull/1153/files.
Testing on Rancher v2.9.1, the allocated translation key is missing. Because current released rancher shell doesn't have that key
The safer way is to use harvester defined translation key
PR Checklist
Related Issue #
harvester/harvester#6362
Screenshot/Video
Test on Rancher 2.9.1
