Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing allocated translation key (backport #1156) #1158

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 20, 2024

Summary

We changed storage title from "Reserved" to "Allocated" in https://github.com/harvester/dashboard/pull/1153/files.

Testing on Rancher v2.9.1, the allocated translation key is missing. Because current released rancher shell doesn't have that key

Screenshot 2024-09-19 at 10 25 57 AM

The safer way is to use harvester defined translation key

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
harvester/harvester#6362

Screenshot/Video

Test on Rancher 2.9.1
Screenshot 2024-09-19 at 11 06 12 AM

Screenshot 2024-09-19 at 11 10 11 AM
This is an automatic backport of pull request #1156 done by [Mergify](https://mergify.com).

@mergify mergify bot added the Backport to v1.3 Backport PR target v1.3 label Sep 20, 2024
@a110605 a110605 merged commit 2dc297c into release-harvester-v1.3 Sep 20, 2024
5 checks passed
@torchiaf torchiaf deleted the mergify/bp/release-harvester-v1.3/pr-1156 branch November 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.3 Backport PR target v1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant