Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix isValid() for VAAPI frame #141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix isValid() for VAAPI frame #141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe536e1
fix for AVAPI frame format
lukasz-misek Nov 5, 2024
ec55c08
valid values for VASurfaceID is > 0
lukasz-misek Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/frame.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,12 @@ class Frame : public FFWrapperPtr<AVFrame>

bool isComplete() const { return m_isComplete; }

bool isValid() const { return (!isNull() && m_raw->data[0] && m_raw->linesize[0]); }
bool isValid() const {
return (!isNull() &&
((m_raw->data[0] && m_raw->linesize[0]) ||
((m_raw->format == AV_PIX_FMT_VAAPI) && ((intptr_t)m_raw->data[3] > 0)))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data[3] contains VASurfaceID, am I right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

);
}

operator bool() const { return isValid() && isComplete(); }

Expand Down