fix isValid() for VAAPI frame #141
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4tr3d
reviewed
Nov 6, 2024
| bool isValid() const { | ||
| return (!isNull() && | ||
| ((m_raw->data[0] && m_raw->linesize[0]) || | ||
| ((m_raw->format == AV_PIX_FMT_VAAPI) && ((intptr_t)m_raw->data[3] > 0))) |
There was a problem hiding this comment.
data[3] contains VASurfaceID, am I right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix frame isValid() method for frames returned from VAAPI decoder.
In this case m_raw->data[0] and m_raw->linesize[0] are both null and m_raw[3] contains vaapi surface id (valid when > 0).