Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict CRLF parsing as per the http spec. #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkothapalli
Copy link

No description provided.

@mkothapalli mkothapalli requested a review from kazuho January 24, 2020 01:43
@Onepamopa
Copy link

Why hasn't this been committed? Any issues with it?

@kenballus
Copy link

This issue still needs to be addressed. The spec clearly states that bare LF is only a valid line terminator for start lines and field lines (i.e. not chunk lines), and the errata makes that explicit:

The difference was intentional. A chunked parser is not a start line or field parser (it is a message body parser) and it is supposed to be less forgiving because it does not have to retain backwards compatibility with 1.0 parsers.

Hence, bare LF around the chunk sizes would be invalid and should result in the connection being marked as invalid.

@kazuho
Copy link
Member

kazuho commented Jan 31, 2024

Agreed that we can and should tighten this. For context, the errata regarding the topic is https://www.rfc-editor.org/errata/eid7633, and the discussion on the mailing list can be found as a thread starting from https://lists.w3.org/Archives/Public/ietf-http-wg/2023JulSep/0159.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants