forbid use of bare LF as chunk header terminator #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
changed the title
|
Do you have an ETA for when this might be committed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #60, RFC 9112 mandates use of CRLF (i.e., forbids use of bare LF) at the end of chunk headers.
This pull request enforces that.
At the same time it continues to accept bare LF inside trailers, as it is a list of fields and RFC 9112 allows parsers to accept bare LFs at the end of each field. This behavior might not be necessary, but it retains consistency with
phr_parse_headerswhich is the function that is used for parsing trailers (note: it is only whenconsume_trailerbit is set that the trailers are consumed byphr_decode_chunked; if the flag is not, it is the responsibility of the application to parse the trailers usingphr_parse_headers).