-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using an auto-generated riff-raff.yaml
file
#947
Conversation
2f726a1
to
546c1be
Compare
env: { | ||
region: 'eu-west-1', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
riff-raff.yaml
generation requires each stack to have the region explicitly set.
}; | ||
|
||
constructor(scope: App, id: string, props: PrismEc2AppProps) { | ||
export class Prism extends GuStack { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The riff-raff.yaml
generator uses the class name for the app
property of the cloud-formation
deployment type. Rename PrismEc2App
to Prism
as the app tag is prism
not prism-ec2-app
.
546c1be
to
1bb68e4
Compare
1bb68e4
to
fb77730
Compare
fb77730
to
57d9b8c
Compare
What does this change?
Switch to using a
riff-raff.yaml
file generated by GuCDK.Whilst this isn't strictly required, this is in preparation to switching to the newly released
GuEc2AppExperimental
.Generated file content
How to test
Testing can be done by using the validation tool to understand the deployment graph, comparing the current (manual) and this (generated).
Ultimately, however, testing is done by deploying and seeing the correct AWS resources being effected:
Indeed, a deployment to CODE has been successful.