feat: Perform EC2 deployments via CloudFormation #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
force-pushed
the
aa/cfn-deploy-only
branch
from
9637877
to
65345f3
Compare
akash1810
force-pushed
the
aa/riff-raff-yaml
branch
from
fb77730
to
57d9b8c
Compare
akash1810
force-pushed
the
aa/cfn-deploy-only
branch
from
f8c5e58
to
74be032
Compare
akash1810
force-pushed
the
aa/cfn-deploy-only
branch
2 times, most recently
from
51d3a6d
to
a2ef5ec
Compare
This is a requirement for using `GuEc2AppExperimental`.
akash1810
force-pushed
the
aa/cfn-deploy-only
branch
from
a2ef5ec
to
69e6f18
Compare
adamnfish
reviewed
Oct 7, 2024
| const pattern = new GuPlayApp(this, { | ||
| const { buildIdentifier } = props; | ||
|
|
||
| const filename = `${app}-${buildIdentifier}.deb`; |
There was a problem hiding this comment.
The most minor thing in the world, but I get a niggle that we could use a different separator character here? Hyphens are commonly to separate words in the artefact name, making the version pop out will help at a glance, and if someone wants to parse it out for any reason later. It looks like sbt-native-packager is using _ as the version delimiter, could we do the same?
There was a problem hiding this comment.
Can do. Will raise a follow-up PR. Would you think we can formalise the use of _? I've been struggling to think how we'd address this TODO - https://github.com/guardian/cdk/blob/890c89e07d6715277ef9db4f01baeafddc7696e8/src/experimental/patterns/ec2-app.ts#L265.
adamnfish
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Uses the new
GuEc2AppExperimentalavailable in GuCDK v59.5.0 to deploy changes to the autoscaling group entirely via a CloudFormation update.How to test
Deploy the branch?! It should succeed. This has been done on CODE.
How can we measure success?
More data points to evaluate the effectiveness of
GuEc2AppExperimental.