chore(lint): Fail on prettier errors
#946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
commented
Sep 19, 2024
There was a problem hiding this comment.
For the most part, this file is generated by GuCDK. It should be adding eslint-plugin-prettier, but it currently doesn't.
jacobwinch
approved these changes
Sep 19, 2024
Configure `eslint` to fail on `prettier` errors. This ensures a consistent style for quote marks, indent levels, etc. It also means the project uses the departmental code style.
akash1810
force-pushed
the
aa/prettier
branch
from
e5f6368
to
0f038a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Configure
eslintto fail onprettiererrors. This ensures a consistent style for quote marks, indent levels, etc. It also means the project uses the departmental code style.This is a no-op, as demonstrated by the CDK snapshot remaining unchanged.