chore(deps): Update GuCDK from 57.0.0 to 59.5.1 #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwinch
previously approved these changes
Sep 19, 2024
akash1810
commented
Sep 19, 2024
| @@ -631,6 +636,7 @@ exports[`The PrismEc2App stack matches the snapshot 1`] = ` | |||
| }, | |||
| "Port": 443, | |||
| "Protocol": "HTTPS", | |||
| "SslPolicy": "ELBSecurityPolicy-TLS13-1-2-2021-06", | |||
There was a problem hiding this comment.
See guardian/cdk#2306.
Comment on lines
+96
to
+100
| "MetricsCollection": [ | ||
| { | ||
| "Granularity": "1Minute", | ||
| }, | ||
| ], |
There was a problem hiding this comment.
See guardian/cdk#2455.
| @@ -1124,6 +1148,7 @@ exports[`The PrismEc2App stack matches the snapshot 1`] = ` | |||
| "InstanceType": "t4g.medium", | |||
| "MetadataOptions": { | |||
| "HttpTokens": "required", | |||
| "InstanceMetadataTags": "enabled", | |||
There was a problem hiding this comment.
See guardian/cdk#2423.
Comment on lines
+63
to
+66
| "quotes": [ | ||
| "error", | ||
| "double" | ||
| ] |
There was a problem hiding this comment.
It looks like the departmental preference is to use single quotes. Overriding that here to keep the diff in this PR as minimal as possible, and thus easier to review. This change will be reverted as it's own PR.
| "module": "CommonJS" | ||
| } | ||
| }, | ||
| "extends": "@guardian/tsconfig/tsconfig.json", |
There was a problem hiding this comment.
Prefer to use the departmental configuration, rather than our own.
Updating GuCDK across 2 major versions includes some breaking changes. These are reflected in the update to the snapshot. Also taken the opportunity to simplify the CDK project by removing redundant files and using `npm` across the board. Fixes #692. Co-authored-by: SarahJessica <[email protected]> chore(deps-dev): Update to 59.5.1
akash1810
force-pushed
the
gucdk-59.5.0
branch
from
fdadb57
to
519fc51
Compare
akash1810
changed the title
jacobwinch
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Update to the latest version of GuCDK.
Updating GuCDK across 2 major versions includes some breaking changes. These are reflected in the update to the snapshot.
The update was done by regenerating the CDK project via:
Consequently a number of files have been deleted as:
script/buildfile, and others like it)package.jsonor replaced by shared departmental configuration, e.g. the changes totsconfig.jsonAnnoyingly some files only include whitespace changes. Therefore its recommended to review w/out them.
Performing the update like this also means we fix #692; we're now using
npmonly.Fixes #692.
Co-authored-by: @SarahJessica