-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce matched peer dependencies in CI #7003
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turn the existing scheduled / cron job into a CI check that fails for any unknown mismatch. A list of known errors allows the current state of affairs to be acknowledged with clear steps towards resolution.
Size Change: -4 B (0%) Total Size: 2.98 MB ℹ️ View Unchanged
|
mxdvl
changed the title
feat(deps): track @types packages
Enforce matched peer dependencies in CI
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Turn the existing scheduled / cron job from from #6946 into a CI check that fails for any unknown mismatch.
Add a list of known errors allows the current state of affairs to be acknowledged with clear steps towards resolution.
Why?
There’s no such thing as loos enforcement. While an existing list of mismatches in #6945 is informative, it does not prevent new mismatches to be added.
Builds on #6966 & #6971
How to test?
An admin can do a workflow dispatch on the action