Track @types/* packages
#6966
Closed
Track @types/* packages
#6966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -720 kB (-24%) 🎉 Total Size: 2.31 MB
ℹ️ View Unchanged
|
jamesgorrie
reviewed
Jan 16, 2023
Agree, also really needs an investment of time to resolve some of the wider issues at play here - visibility is great but it doesn't fix anything. I think when everyone is ready to upgrade to React 18 there will scope to eliminate at least a few of the mismatches. |
mxdvl
force-pushed
the
mxdvl/types-mismatch
branch
from
839aeeb to
df51e7c
Compare
|
(Sorry I (Joe) just edited this by mistake) Max said something like: I think its worthwhile spending some time fixing the existing issues. One of the problems we have currently is that we can't add a test to check for mismatches as there are already a lot of them. One way to get this to pass in CI would be to add a list of “known issues”, for example: /* if the mismatches is in this list, warn instead of error */
const ignores = [
ajv,
compression,
he,
jest,
jsdom,
react,
react-dom,
webpack-node-externals,
] |
Mismatches in @types packages significantly reduce any type safety gained by using TypeScript. Create a regularly updating issue that tracks all `major.minor` versions for packages with a matching `@types/*`.
mxdvl
force-pushed
the
mxdvl/types-mismatch
branch
from
df51e7c to
453ded8
Compare
Use tilde ranges for packages with a type definition, as this is what the contract from DefinitelyTyped expects https://github.com/DefinitelyTyped/DefinitelyTyped#how-do-definitely-typed-package-versions-relate-to-versions-of-the-corresponding-library https://github.com/npm/node-semver#tilde-ranges-123-12-1
I’ve now merged the tilde range CI action from #6971, @joecowton1 & @jamesgorrie, which addresses these concerns. |
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
Okay thanks! In that case I'll add the |
bryophyta
added
the
prnouncer-ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Create a regularly updating issue (#6965) that tracks all
major.minorversions for packages with a matching@types/*.Why?
Mismatches in @types packages significantly reduce any type safety gained by using TypeScript.
Screenshots