Use user benefits abtest #13137
Merged
Use user benefits abtest #13137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: +231 B (+0.03%) Total Size: 884 kB
ℹ️ View Unchanged
|
johnduffell
reviewed
Jan 14, 2025
johnduffell
reviewed
Jan 14, 2025
johnduffell
reviewed
Jan 14, 2025
| }, | ||
| ); | ||
| if (!validateResponse(response)) { | ||
| throw new Error('invalid response'); |
There was a problem hiding this comment.
presumably that will throw an alarm somewhere for us/sentry?
There was a problem hiding this comment.
I guess? Not sure, this is the same as the previous implementation
There was a problem hiding this comment.
true I guess the more pertinent question is how will you know that everything is working with the new API like it was before across a similar percentage of browsers
rupertbates
force-pushed
the
use-user-benefits-abtest
branch
from
36dece9 to
c6c44a0
Compare
rupertbates
force-pushed
the
use-user-benefits-abtest
branch
from
c6c44a0 to
65ecce9
Compare
github-actions
bot
removed
the
run_chromatic
rupertbates
force-pushed
the
use-user-benefits-abtest
branch
from
d5cd1f1 to
8263a51
Compare
7 tasks
rupertbates
force-pushed
the
use-user-benefits-abtest
branch
from
2de412d to
549714f
Compare
github-actions
bot
removed
the
run_chromatic
tjmw
reviewed
Jan 20, 2025
| return Promise.reject('The user is not signed in'); | ||
| } | ||
| if (shouldUseUserBenefitsApi()) { | ||
| return syncDataFromUserBenefitsApi(authStatus).then(persistResponse); |
There was a problem hiding this comment.
This is neat that both methods return value of the same shape (so can use persistResponse in both cases).
tjmw
approved these changes
Jan 20, 2025
| ): Promise<UserBenefits> => { | ||
| const response = await fetchJson( | ||
| window.guardian.config.page.userBenefitsApiUrl ?? | ||
| '/USER_BENEFIT_API_NOT_FOUND', |
There was a problem hiding this comment.
Would it be clearer/more explicit to error in the case that the url isn't set in config? (Rather than making a request to a non-existent URL?)
There was a problem hiding this comment.
I did think that as well, but I stuck with the way it was written already. Happy to change it, what do you think?
There was a problem hiding this comment.
I went ahead and changed it.
There was a problem hiding this comment.
Ah great, yeah I think it feels like there'd be less scope for confusion when debugging an issue that way 👍
|
The screenshots in the descrtiption appear as broken images for me. Out of interest wouldn't this have been ok as a client side "AB test" (which would presumably avoid splitting the cache?) |
rupertbates
force-pushed
the
use-user-benefits-abtest
branch
from
c2ec95d to
9709c95
Compare
The test needs to be used too early in the page load for a client side test because they rely on React being available. |
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @rupertbates 7 minutes and 47 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the new user-benefits api as a source of information about what benefits (ad-free, hide support messaging) a user is entitled to.
The switch over to the new API is going to be managed with an server side AB test to allow us to control the amount of traffic going to the new service.
This PR requires support-service-lambdas to handles CORS