Throw an error immediately if urls are missing from config.

guardian · Jan 20, 2025 · c2ec95d · c2ec95d
1 parent 549714f
commit c2ec95d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 18 deletions.
diff --git a/dotcom-rendering/src/client/userFeatures/membersDataApi.ts b/dotcom-rendering/src/client/userFeatures/membersDataApi.ts
@@ -87,16 +87,14 @@ export const syncDataFromMembersDataApi: (
 ) => Promise<UserBenefits> = async (
 	signedInAuthStatus: SignedInWithOkta | SignedInWithCookies,
 ) => {
-	const response = await fetchJson(
-		`${
-			window.guardian.config.page.userAttributesApiUrl ??
-			'/USER_ATTRIBUTE_API_NOT_FOUND'
-		}/me`,
-		{
-			mode: 'cors',
-			...getOptionsHeadersWithOkta(signedInAuthStatus),
-		},
-	);
+	const url = window.guardian.config.page.userAttributesApiUrl;
+	if (!url) {
+		throw new Error('userAttributesApiUrl is not defined');
+	}
+	const response = await fetchJson(url, {
+		mode: 'cors',
+		...getOptionsHeadersWithOkta(signedInAuthStatus),
+	});
 	if (!validateResponse(response)) {
 		throw new Error('invalid response');
 	}

diff --git a/dotcom-rendering/src/client/userFeatures/userBenefitsApi.ts b/dotcom-rendering/src/client/userFeatures/userBenefitsApi.ts
@@ -13,14 +13,14 @@ type UserBenefitsResponse = {
 export const syncDataFromUserBenefitsApi = async (
 	signedInAuthStatus: SignedInWithOkta | SignedInWithCookies,
 ): Promise<UserBenefits> => {
-	const response = await fetchJson(
-		window.guardian.config.page.userBenefitsApiUrl ??
-			'/USER_BENEFIT_API_NOT_FOUND',
-		{
-			mode: 'cors',
-			...getOptionsHeadersWithOkta(signedInAuthStatus),
-		},
-	);
+	const url = window.guardian.config.page.userBenefitsApiUrl;
+	if (!url) {
+		throw new Error('userBenefitsApiUrl is not defined');
+	}
+	const response = await fetchJson(url, {
+		mode: 'cors',
+		...getOptionsHeadersWithOkta(signedInAuthStatus),
+	});
 	if (!validateResponse(response)) {
 		throw new Error('invalid response');
 	}