chore: drop dependencies on axios and form-data #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Closed
korniltsev
approved these changes
Mar 10, 2025
|
@haines is there anything else on this PR? Are you going to merge it? |
Contributor
Author
|
@huyvnn it's finished as far as I'm concerned. I'm not a maintainer of this project though (just a user of the package), so I can't merge it myself. |
|
@korniltsev Thanks! Would it be possible to cut a new release with this? It’d be really helpful. Appreciate it! |
Contributor
|
https://github.com/grafana/pyroscope-nodejs/actions/runs/13916759662/job/38941124522 |
Contributor
|
Published https://www.npmjs.com/package/@pyroscope/nodejs/v/0.4.4 Let us know if there are any issues. Thank you for the contribution. |
|
Cool. Thank you, all. |
simonswine
added a commit
to simonswine/pyroscope-nodejs
that referenced
this pull request
Mar 22, 2025
Basic auth was broken by grafana#112
simonswine
added a commit
that referenced
this pull request
Mar 24, 2025
* Fix basic auth Basic auth was broken by #112 * Fixing tests Unfortunately the tests were broken, when we migrated to vitest, as the (done), callback is no longer supported in there. I have refactored those a fair bit and it should be all working again. * Update test/profiler.test.ts Co-authored-by: Tolya Korniltsev <[email protected]> * Cleanup at test finish --------- Co-authored-by: Tolya Korniltsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111
This PR replaces the use of third-party dependencies with the
fetchAPI.