fix: Basic auth (was broken in v0.4.4) and test were not running #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic auth was broken by grafana#112
Unfortunately the tests were broken, when we migrated to vitest, as the (done), callback is no longer supported in there. I have refactored those a fair bit and it should be all working again.
simonswine
changed the title
simonswine
changed the title
korniltsev
approved these changes
Mar 24, 2025
Contributor
korniltsev
left a comment
korniltsev
left a comment
There was a problem hiding this comment.
LGTM
Thanks for fixing the tests!
Co-authored-by: Tolya Korniltsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task started with fix the broken basic auth, reported in #114, caused by #112
What I figured out is that our test are actually not waiting for the profile and therefore pretty useless (since #94), I fixed this as well and added authentication tests too.
Fixes #114