Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric_aggregation): Fix duplicate metrics registration #15142

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented Nov 27, 2024

What this PR does / why we need it:

Fixes duplicate metric registration in metric aggregation in pattern ingesters. I used promauto.With(reg) along with m.reg.MustRegister(... that resulted in duplicate registration

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@shantanualsi shantanualsi requested a review from a team as a code owner November 27, 2024 06:25
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 27, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 27, 2024
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli added type/bug Somehing is not working as expected backport k230 labels Nov 27, 2024
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 27, 2024

This PR must be merged before a backport PR will be created.

@shantanualsi shantanualsi merged commit 215f994 into main Nov 27, 2024
62 checks passed
@shantanualsi shantanualsi deleted the shantanu/fix-pattern-ingester-duplicate-reg branch November 27, 2024 08:14
loki-gh-app bot pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k230 size/L type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants