Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric_aggregation): Fix duplicate metrics registration (backport k230) #15144

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Nov 27, 2024

Backport 215f994 from #15142


What this PR does / why we need it:

Fixes duplicate metric registration in metric aggregation in pattern ingesters. I used promauto.With(reg) along with m.reg.MustRegister(... that resulted in duplicate registration

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot added the backport label Nov 27, 2024
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner November 27, 2024 08:15
@loki-gh-app loki-gh-app bot added size/L type/bug Somehing is not working as expected labels Nov 27, 2024
@shantanualsi shantanualsi merged commit 1057389 into k230 Nov 27, 2024
64 checks passed
@shantanualsi shantanualsi deleted the backport-15142-to-k230 branch November 27, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/L type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant