Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: hotfix removed loki-stack typo #15074

Merged
merged 2 commits into from
Nov 22, 2024
Merged

docs: hotfix removed loki-stack typo #15074

merged 2 commits into from
Nov 22, 2024

Conversation

Jayclifford345
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Jayclifford345 Jayclifford345 requested a review from a team as a code owner November 22, 2024 13:50
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 22, 2024
@Jayclifford345 Jayclifford345 self-assigned this Nov 22, 2024
JStickler
JStickler approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 22, 2024

This PR must be merged before a backport PR will be created.

3 similar comments
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 22, 2024

This PR must be merged before a backport PR will be created.

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 22, 2024

This PR must be merged before a backport PR will be created.

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 22, 2024

This PR must be merged before a backport PR will be created.

@JStickler JStickler mentioned this pull request Nov 22, 2024
Closed
6 tasks
@JStickler JStickler merged commit 048df5f into main Nov 22, 2024
67 checks passed
@JStickler JStickler deleted the Jayclifford345-patch-1 branch November 22, 2024 20:10
loki-gh-app bot pushed a commit that referenced this pull request Nov 22, 2024
@Jayclifford345 @grafana-delivery-bot
docs: hotfix removed loki-stack typo (#15074)
83630bd 
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 048df5f)
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 22, 2024
Merged
6 tasks
loki-gh-app bot pushed a commit that referenced this pull request Nov 22, 2024
@Jayclifford345 @grafana-delivery-bot
docs: hotfix removed loki-stack typo (#15074)
6f442d1 
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 048df5f)
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 22, 2024
Merged
6 tasks
loki-gh-app bot pushed a commit that referenced this pull request Nov 22, 2024
@Jayclifford345 @grafana-delivery-bot
docs: hotfix removed loki-stack typo (#15074)
2ceccf4 
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 048df5f)
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 22, 2024
Merged
6 tasks
loki-gh-app bot pushed a commit that referenced this pull request Nov 22, 2024
@Jayclifford345 @grafana-delivery-bot
docs: hotfix removed loki-stack typo (#15074)
8197108 
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 048df5f)
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 22, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees

@Jayclifford345 Jayclifford345

Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x backport release-3.3.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jayclifford345 @JStickler