Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update _index.md to change loki-stack reference #15047

Closed
wants to merge 1 commit into from

Conversation

rrussell0
Copy link

Changes reference to loki-stack to loki as loki-stack is deprecated

What this PR does / why we need it:
Changes reference to loki-stack chart that is deprecated to the correct loki chart

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
Ran into this issue last night when installing Loki for the first time - using the old deprecated chart causes the config to not work.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Changes reference to loki-stack to loki as loki-stack is deprecated
@rrussell0 rrussell0 requested a review from a team as a code owner November 20, 2024 20:10
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 20, 2024
@trevorwhitney
Copy link
Collaborator

@rrussell0 please sign the CLA agreement, thanks for the contribution!

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 21, 2024

This PR must be merged before a backport PR will be created.

3 similar comments
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 21, 2024

This PR must be merged before a backport PR will be created.

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 21, 2024

This PR must be merged before a backport PR will be created.

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 21, 2024

This PR must be merged before a backport PR will be created.

@JStickler
Copy link
Contributor

JStickler commented Nov 22, 2024

Closed via #15074.

@JStickler JStickler closed this Nov 22, 2024
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 22, 2024

This PR must be merged before a backport PR will be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x backport release-3.3.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants