Skip to content

Move isFallbackAdapter into GPUAdapterInfo #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kainino0x merged 3 commits into from
Mar 21, 2025
Merged

Move isFallbackAdapter into GPUAdapterInfo #171

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c5e20f
Move isFallbackAdapter into GPUAdapterInfo
beaufortfrancois Mar 20, 2025
5c6ab12
Address feedback
beaufortfrancois Mar 21, 2025
d295375
nits
kainino0x Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions dist/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,7 +1344,7 @@ interface GPURequestAdapterOptions {
* {@link GPURequestAdapterOptions#forceFallbackAdapter} is set to `false` and either no
* other appropriate adapter is available or the user agent chooses to return a
* fallback adapter. Developers that wish to prevent their applications from running on
* fallback adapters should check the {@link GPUAdapter}.{@link GPUAdapter#isFallbackAdapter}
* fallback adapters should check the {@link GPUAdapter#info}.{@link GPUAdapterInfo#isFallbackAdapter}
* attribute prior to requesting a {@link GPUDevice}.
*/
forceFallbackAdapter?: boolean;
Expand Down Expand Up @@ -1979,8 +1979,11 @@ interface GPUAdapter {
readonly info: GPUAdapterInfo;
/**
* Returns the value of {@link GPUAdapter#[[adapter]]}.{@link adapter#[[fallback]]}.
*
* @deprecated Use {@link GPUAdapterInfo#isFallbackAdapter}.
* (Note if it's not available, it will be `undefined` which is still falsy.)
*/
readonly isFallbackAdapter: boolean;
readonly isFallbackAdapter?: boolean;
/**
* Requests a device from the adapter.
* This is a one-time action: if a device is returned successfully,
Expand Down Expand Up @@ -2039,6 +2042,10 @@ interface GPUAdapterInfo {
* adapter.
*/
readonly subgroupMaxSize: number;
/**
* Whether the adapter is a fallback adapter.
**/
readonly isFallbackAdapter?: boolean;
}

declare var GPUAdapterInfo: {
Expand Down
Loading