Move isFallbackAdapter into GPUAdapterInfo#171
Merged
Conversation
kainino0x
reviewed
Mar 20, 2025
Collaborator
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
Can we roll the gpuweb dependency so that this change shows up in the generated/ version too?
Contributor
Author
|
@kainino0x I've addressed all your feedback. Thanks! |
kainino0x
reviewed
Mar 21, 2025
kainino0x
approved these changes
Mar 21, 2025
Collaborator
|
Published, along with a bunch of other stuff I randomly decided to deal with today, as version 0.1.58 |
Contributor
Author
|
Thank you @kainino0x! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following gpuweb/gpuweb#5099, this PR moves
isFallbackAdapterintoGPUAdapterInfo