Detect atomic support using target_has_atomic #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
target-has-atomic
branch
5 times, most recently
from
f1c0024
to
adca09e
Compare
|
As-is, this does not put all uses of atomics behind |
Base automatically changed from
impl-for-transparent-wrapper-soundness
to
main
August 13, 2024 00:33
joshlf
force-pushed
the
target-has-atomic
branch
3 times, most recently
from
df53350
to
ea6621a
Compare
joshlf
force-pushed
the
target-has-atomic
branch
2 times, most recently
from
3cbe102
to
161a694
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1586 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 15 15
Lines 5565 5565
=======================================
Hits 4881 4881
Misses 684 684 ☔ View full report in Codecov by Sentry. |
joshlf
force-pushed
the
target-has-atomic
branch
3 times, most recently
from
0bc9d36
to
c3e7afc
Compare
jswrenn
approved these changes
Aug 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
joshlf
force-pushed
the
target-has-atomic
branch
from
c3e7afc
to
cbe9f8b
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
joshlf
force-pushed
the
target-has-atomic
branch
from
cbe9f8b
to
20614e8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
joshlf
force-pushed
the
target-has-atomic
branch
from
20614e8
to
866b645
Compare
joshlf
force-pushed
the
target-has-atomic
branch
4 times, most recently
from
8dc08a2
to
50f3cb6
Compare
joshlf
force-pushed
the
target-has-atomic
branch
from
50f3cb6
to
fd749c2
Compare
Implements `TryFromBytes` and `FromZeros` for `AtomicPtr`; `FromBytes` and `IntoBytes` are blocked by #170. This is adapted from @josephlr's similar implementation in #1092. Fixes #1086 Co-authored-by: Joe Richey <[email protected]>
joshlf
force-pushed
the
target-has-atomic
branch
from
fd749c2
to
5205f60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
TryFromBytesandFromZerosforAtomicPtr;FromBytesandIntoBytesare blocked by #170.This is adapted from @josephlr's similar implementation in #1091.
Fixes #1086