You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#1586 gates impls of zerocopy traits for atomic types on target_has_atomic = "xxx", ensuring that we don't emit invalid impls. On its own, that PR is correct, but attempts to be minimal in order to make quick progress and to avoid lumping a large refactor into what would otherwise be a small PR.
Separately, we should follow up and clean up atomics support in general:
Consider co-locating the definition of unsafe_impl_transparent_wrapper_for_atomic! (in util in #1586) with its uses (in impls in #1586). Note that we may also want to avoid doing that since reasoning about the soundness of the body of that macro requires understanding the semantics of TransparentWrapper, so having it next to the definition of TransparentWrapper might be good.
#1586 gates impls of zerocopy traits for atomic types on
target_has_atomic = "xxx"
, ensuring that we don't emit invalid impls. On its own, that PR is correct, but attempts to be minimal in order to make quick progress and to avoid lumping a large refactor into what would otherwise be a small PR.Separately, we should follow up and clean up atomics support in general:
unsafe_impl_transparent_wrapper_for_atomic!
(inutil
in #1586) with its uses (inimpls
in #1586). Note that we may also want to avoid doing that since reasoning about the soundness of the body of that macro requires understanding the semantics ofTransparentWrapper
, so having it next to the definition ofTransparentWrapper
might be good.Atomic
trait as prototyped in Gate implementations for Atomic* types behind #[cfg(target_has_atomic)] and Rust 1.60 #1091The text was updated successfully, but these errors were encountered: