Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MjHingeJoint.cs range with MakeLocaleInvariant #1721

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix MjHingeJoint.cs range with MakeLocaleInvariant #1721

wants to merge 1 commit into from

Conversation

stonfute
Copy link
Contributor

@stonfute stonfute commented Jun 5, 2024 •
edited
Loading

Seems to fix issues #1394 #845 by using localeInvariant on range

@Balint-H
Copy link
Collaborator

Balint-H commented Jun 11, 2024 •
edited
Loading

@erez-tom LGTM!

Thanks for the contribution @stonfute! It doesn't completely fix #1709, but #845 could be solved by this (pending on confirmation from the issue's original author)

@stonfute
Copy link
Contributor Author

stonfute commented Jun 11, 2024 •
edited
Loading

It doesn't completely fix #1709, but #845 could be solved by this (pending on confirmation from the issue's original author)

My bad, wrong issue mentioned. I meant it will fix #845 according to sample xml provided. And also related to #1394 (hinge joint part with range issue)

@Balint-H
Copy link
Collaborator

@erez-tom Hello Tom, I think this is still a fix pending that we need. Is there anything else that needs to be done before merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stonfute @Balint-H