New Storage Driver: Minio #962
Conversation
|
thx for the effort
before we start with the code review |
minio/go.mod
Outdated
| github.com/klauspost/compress v1.16.7 // indirect | ||
| github.com/klauspost/cpuid/v2 v2.2.5 // indirect | ||
| github.com/minio/md5-simd v1.1.2 // indirect | ||
| github.com/minio/minio-go/v7 v7.0.62 // indirect |
There was a problem hiding this comment.
why is it marked as indirect?
There was a problem hiding this comment.
auto-attached was not my choice
|
currently not sure what the difference is between the current s3 storage adapters and these if the underlying endpoints are the same what added value does this implementation offer compared to the current s3 adapter? |
The current s3 adapter is written for aws, aws s3 is paid, minio is an open source project. |
|
ok thx for the explanation |
S3 is a protocol though, you can use the https://github.com/gofiber/storage/blob/main/.github/workflows/test-s3.yml#L24 |
|
I was looking around and it's more simple than the official S3 one. So it makes sense |
|
pls refresh with the master |
|
I have to re-review the unit-tests. Overall it looks fine. I'm just a little concern with the extra Public functions allowing the user to Create and Remove buckets. This is very to the behavior of the S3 driver. Does Minio let you upload data as bytes or strings? Instead of having to upload "files"? |
Minio PutObject requests io.Reader just like s3 PutObject. |
|
Why use Minio Client over S3 Sdk? Since Minio Client implements the Amazon S3 API, it can work not only with Amazon S3 but also with other Amazon S3-compatible object storage solutions. This can enhance the customizability and independence of your project. If you have the possibility of transitioning to a different compatible object storage solution in the future, using Minio Client could make this transition smoother. Minio Client can address a wider range of use case scenarios beyond just Amazon S3. It gives you the ability to target different compatible storage servers or services, not limited to Amazon S3. Minio Client is a tool developed and supported in alignment with open source projects. This could also be seen as a way to contribute to the development and improvement of the open source community. Minio Client might offer a user-friendly interface to enhance developer experience. Especially when working with a Minio server, tasks performed through Minio Client could be faster and more straightforward. If you have developers familiar with Minio Client usage on your team or if your team better understands Minio Client, this could influence your choice. Similarly, if there's already a pre-existing infrastructure based on Minio Client usage, it could be a factor to consider. If you are building a project specifically tailored to work on a Minio server, using Minio Client could provide a more direct and integrated way of working with this server. |
|
@mstgnz Can we get rid of a the "CheckBucket" calls on each function. When the call happens if the bucket doesnt exist it should throw an error anyways. It's up to the user to check the error and create the bucket. |
|
OK, I'll have to adjust the test accordingly. edit: bucket check control for get, set, delete and reset has been removed. And update test @gaby |
Description
Hello Fiber Team,
With this pull request, I'm introducing the MinIO S3 driver to Fiber's array of storage drivers. MinIO, a high-performance and scalable object storage system designed for modern cloud-native applications, brings exceptional speed and resilience.
Why MinIO?
MinIO is an ideal solution for projects that demand speed, durability, and scalability, making it particularly suitable for cases with significant data loads and high traffic. By incorporating this solution into the Fiber project, we can better address larger workloads and handle intensive traffic scenarios.
How Can This Help?
This pull request adds the MinIO S3 driver integration. I've expanded the existing test coverage by adding new test scenarios and documented how to integrate using sample code.
Please review and share your feedback. I'm open to any changes or suggestions for improvements. I'm excited to contribute to the Fiber project and believe that the MinIO integration can provide valuable advantages to our community.