You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I understand current s3 implementation is designed for gofiber Storage interface, but it could be used as a s3 library too.
My question is, do you accept PR to add a new function alternative to Set() to accept checksum (e.g. sha256)? so that S3 server will verify the data integrity on server side.
The plan is adding new functions to accept checksum like below (since theses functions are not designed for Storage interface, i removed exp time.Duration):
SetWithChecksumCRC32(key string, val []byte, checksum string)
SetWithChecksumCRC32C(key string, val []byte, checksum string)
SetWithChecksumSHA1(key string, val []byte, checksum string)
SetWithChecksumSHA256(key string, val []byte, checksum string)
Or, one function to support all (checksum map[string]string, key is checksum algorithm like CRC32, SHA256, value is the checksum):
SetWithChecksum(key string, val []byte, checksum map[string]string)
Feature Description
I understand current s3 implementation is designed for gofiber Storage interface, but it could be used as a s3 library too.
My question is, do you accept PR to add a new function alternative to
Set()
to accept checksum (e.g. sha256)? so that S3 server will verify the data integrity on server side.Current
Set()
doesn't accept any checksum:https://github.com/gofiber/storage/blob/main/s3/s3.go#L95C39-L99
The plan is adding new functions to accept checksum like below (since theses functions are not designed for Storage interface, i removed
exp time.Duration
):Or, one function to support all (
checksum map[string]string
, key is checksum algorithm likeCRC32
,SHA256
, value is the checksum):Your opinion?
Additional Context (optional)
No response
Code Snippet (optional)
No response
Checklist:
The text was updated successfully, but these errors were encountered: