Add String::remove_char(s) methods for performance and convenience
#92476
+205
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
String::remove_char(s) methods for performance and convenience
Mickeon
reviewed
Jun 23, 2024
AThousandShips
force-pushed
the
string_remove_char
branch
from
bfe4f1e to
a57b76c
Compare
AThousandShips
force-pushed
the
string_remove_char
branch
from
a57b76c to
98547f9
Compare
AThousandShips
force-pushed
the
string_remove_char
branch
from
98547f9 to
13d165a
Compare
AThousandShips
commented
Aug 28, 2024
| @@ -1849,7 +1849,7 @@ void EditorHelp::_update_doc() { | |||
| _push_code_font(); | |||
|
|
|||
| if (constant.value.begins_with("Color(") && constant.value.ends_with(")")) { | |||
| String stripped = constant.value.replace(" ", "").replace("Color(", "").replace(")", ""); | |||
| String stripped = constant.value.remove_char(' ').replace("Color(", "").remove_char(')'); | |||
There was a problem hiding this comment.
Could change this to:
Suggested change
| String stripped = constant.value.remove_char(' ').replace("Color(", "").remove_char(')'); | |
| String stripped = constant.value.remove_chars({ ' ', ')' }).replace("Color(", ""); |
But since the original code keeps the two removes separate I'm unsure if it might cause some issues so left it for now, but if it's considered safe I'll change this
AThousandShips
commented
Aug 28, 2024
AThousandShips
force-pushed
the
string_remove_char
branch
from
13d165a to
de7f94f
Compare
AThousandShips
force-pushed
the
string_remove_char
branch
from
de7f94f to
e79b33c
Compare
AThousandShips
force-pushed
the
string_remove_char
branch
from
e79b33c to
48f14fc
Compare
AThousandShips
force-pushed
the
string_remove_char
branch
from
48f14fc to
98ad2ff
Compare
AThousandShips
force-pushed
the
string_remove_char
branch
from
98ad2ff to
8978147
Compare
AThousandShips
force-pushed
the
string_remove_char
branch
from
8978147 to
92fc76a
Compare
|
Added an alternative approach based on the changes in: |
AThousandShips
force-pushed
the
string_remove_char
branch
3 times, most recently
from
43828aa to
d1e2a8e
Compare
AThousandShips
force-pushed
the
string_remove_char
branch
from
d1e2a8e to
96e0fde
Compare
AThousandShips
force-pushed
the
string_remove_char
branch
from
96e0fde to
de97b60
Compare
|
Reworked with the same logic as the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to:
String::replace_char(s)methods for performance and convenience #92475With essentially the same logic and considerations, see there for more reasoning. Will also perform benchmarks on this PR and see about exposing these if desired.
Named it
removeas the existingerasemethod is very different so wanting to avoid confusion between the two.