Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of multi line text #590

Merged
merged 9 commits into from
Dec 14, 2024
Merged

Fix parsing of multi line text #590

merged 9 commits into from
Dec 14, 2024

Conversation

goccy
Copy link
Owner

@goccy goccy commented Dec 14, 2024

Current YAML Test Suite Status: total:[402] passed:[342] failure:[60] passedRate:[85.074631%]
There are only 4 test cases left that succeed exclusively with gopkg.in/yaml.v3

@goccy goccy changed the title Fix parser of multi line text Fix parsing of multi line text Dec 14, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.95122% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.43%. Comparing base (7601ad3) to head (025dbe6).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   77.37%   77.43%   +0.06%     
==========================================
  Files          21       21              
  Lines        7704     7738      +34     
==========================================
+ Hits         5961     5992      +31     
- Misses       1333     1335       +2     
- Partials      410      411       +1     

@goccy goccy merged commit a692a58 into master Dec 14, 2024
19 checks passed
@goccy goccy deleted the fix-parser branch December 14, 2024 11:08
if c.docFirstLineIndentColumn > c.docLineIndentColumn {
return errors.New("invalid number of indent is specified in the document header")
if s.firstLineIndentColumn > s.lineIndentColumn {
return errors.New("invalid number of indent is specified in the multi line header")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return errors.New("invalid number of indent is specified in the multi line header")
return errors.New("invalid number of indent is specified in the multi-line header")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants