Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unexported funcs by removing unnecessary error result #589

Closed

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Dec 13, 2024

Before submitting your PR, please confirm the following.

  • Describe the purpose for which you created this PR.
  • Create test code that corresponds to the modification

The PR removes error result from newMappingNode and createLiteralAndFoldedTokenGroups functions as it is always nil. This increases code coverage and removes unreachable paths.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (7601ad3) to head (2b30585).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage   77.37%   77.46%   +0.09%     
==========================================
  Files          21       21              
  Lines        7704     7695       -9     
==========================================
  Hits         5961     5961              
+ Misses       1333     1327       -6     
+ Partials      410      407       -3     

@goccy
Copy link
Owner

goccy commented Dec 13, 2024

Did you see my comment? I don't require refactoring PR

#555 (comment)

@alexandear alexandear closed this Dec 13, 2024
@alexandear alexandear deleted the refactor-remove-err-result branch December 13, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants