Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of directive value #578

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Fix parsing of directive value #578

merged 4 commits into from
Dec 9, 2024

Conversation

goccy
Copy link
Owner

@goccy goccy commented Dec 9, 2024

Breaking Changes

ast.DirectiveNode has the Name and Values field.

  • Name: directive name e.g.) YAML or TAG
  • Values : directive values e.g.) 1.2 or !! tag:clarkevans.com,2002:app/

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.00592% with 49 lines in your changes missing coverage. Please review.

Project coverage is 77.39%. Comparing base (264b167) to head (e646ff7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
- Coverage   77.48%   77.39%   -0.10%     
==========================================
  Files          21       21              
  Lines        7502     7630     +128     
==========================================
+ Hits         5813     5905      +92     
- Misses       1293     1318      +25     
- Partials      396      407      +11     

@goccy goccy merged commit 438f2d0 into master Dec 9, 2024
19 checks passed
@goccy goccy deleted the fix-directive branch December 9, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants