Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent unwanted promotions of integers to float (Issue 427) #516

Closed
wants to merge 1 commit into from
Closed

prevent unwanted promotions of integers to float (Issue 427) #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions encode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,14 @@ func (e *Encoder) encodeFloat(v float64, bitSize int) ast.Node {
// append x.0 suffix to keep float value context
value = fmt.Sprintf("%s.0", value)
}

// prevent unwanted promotions of integers to float (Issue 427)
intVal := int64(v)
if float64(intVal) == v {
value := fmt.Sprint(intVal)
return ast.Integer(token.New(value, value, e.pos(e.column)))
}

return ast.Float(token.New(value, value, e.pos(e.column)))
}

Expand Down
Loading