Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect colon indicator scanning #485

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

semihbkgr
Copy link
Contributor

@semihbkgr semihbkgr commented Oct 28, 2024

fixes #484

isNextEOS should return true when the next idx is out of src

  • Describe the purpose for which you created this PR.
  • Create test code that corresponds to the modification

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.76%. Comparing base (558921a) to head (bd078f0).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   77.85%   77.76%   -0.09%     
==========================================
  Files          17       17              
  Lines        5797     5819      +22     
==========================================
+ Hits         4513     4525      +12     
- Misses       1013     1022       +9     
- Partials      271      272       +1     

Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the test case for fixing

@goccy goccy added the reviewed label Oct 28, 2024
@semihbkgr semihbkgr requested a review from goccy October 28, 2024 14:10
Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution ! LGTM 👍

@goccy goccy merged commit c7e80a3 into goccy:master Oct 28, 2024
18 checks passed
@abrander abrander mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect colon indicator scanning
3 participants