Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(printer): Add support for formatting comment nodes #469

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

gabe565
Copy link
Contributor

@gabe565 gabe565 commented Jul 29, 2024

Hi!

I use printer to colorize YAML output to a terminal here (see also: yq color printer), and would like to print comments in gray. This PR adds support for formatting comment nodes.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.69%. Comparing base (237df0e) to head (d30e09a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   78.77%   78.69%   -0.08%     
==========================================
  Files          13       13              
  Lines        4004     4008       +4     
==========================================
  Hits         3154     3154              
- Misses        591      595       +4     
  Partials      259      259              

Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !! LGTM 👍

@goccy goccy merged commit 76e8f60 into goccy:master Oct 28, 2024
17 checks passed
@gabe565 gabe565 deleted the printer-comment-nodes branch October 29, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants