Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value mistakenly parsed as number #437

Closed
wants to merge 1 commit into from

Conversation

iliakap
Copy link

@iliakap iliakap commented Mar 19, 2024

fixes #435

  • Describe the purpose for which you created this PR.
  • Create test code that corresponds to the modification

Feel free to comment with suggestions, thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #437 (453f081) into master (4653a1b) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   76.02%   76.02%           
=======================================
  Files          13       13           
  Lines        4692     4692           
=======================================
  Hits         3567     3567           
  Misses        866      866           
  Partials      259      259           

@iliakap iliakap changed the title Fix value mistakenly prsed as number Fix value mistakenly parsed as number Mar 26, 2024
@iliakap
Copy link
Author

iliakap commented Mar 26, 2024

@goccy tell me what you think, pretty sure it's solving the bug

@goccy
Copy link
Owner

goccy commented Nov 6, 2024

@iliakap Thank you for your contribution ! I've fixed this problem with #509

@goccy goccy closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token incorrectly identified as Integer
3 participants