Fix quoted comments #370
Merged
Fix quoted comments #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goccy
requested changes
May 31, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
==========================================
+ Coverage 75.61% 75.98% +0.36%
==========================================
Files 13 13
Lines 4650 4692 +42
==========================================
+ Hits 3516 3565 +49
+ Misses 874 867 -7
Partials 260 260 |
goccy
reviewed
Sep 14, 2023
goccy
reviewed
Sep 14, 2023
|
@WillAbides Sorry for the long wait, I made a couple of comments. |
goccy
approved these changes
Sep 15, 2023
renovate bot
referenced
this pull request
in anoriqq/qpm
Sep 15, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/goccy/go-yaml](https://togithub.com/goccy/go-yaml) | require | patch | `v1.11.1` -> `v1.11.2` | --- ### Release Notes <details> <summary>goccy/go-yaml (github.com/goccy/go-yaml)</summary> ### [`v1.11.2`](https://togithub.com/goccy/go-yaml/releases/tag/v1.11.2): 1.11.2 [Compare Source](https://togithub.com/goccy/go-yaml/compare/v1.11.1...v1.11.2) #### What's Changed - Fix handle of space at start or last by [@​ozraru](https://togithub.com/ozraru) in [https://github.com/goccy/go-yaml/pull/376](https://togithub.com/goccy/go-yaml/pull/376) - Fix quoted comments by [@​WillAbides](https://togithub.com/WillAbides) in [https://github.com/goccy/go-yaml/pull/370](https://togithub.com/goccy/go-yaml/pull/370) - Fix sequence with comment by [@​goccy](https://togithub.com/goccy) in [https://github.com/goccy/go-yaml/pull/390](https://togithub.com/goccy/go-yaml/pull/390) - bump actions/checkout v4 by [@​shogo82148](https://togithub.com/shogo82148) in [https://github.com/goccy/go-yaml/pull/391](https://togithub.com/goccy/go-yaml/pull/391) - add Go 1.21 to the build matrix by [@​shogo82148](https://togithub.com/shogo82148) in [https://github.com/goccy/go-yaml/pull/392](https://togithub.com/goccy/go-yaml/pull/392) - apply go fmt with Go 1.21 by [@​shogo82148](https://togithub.com/shogo82148) in [https://github.com/goccy/go-yaml/pull/394](https://togithub.com/goccy/go-yaml/pull/394) - bump actions/setup-go v4 by [@​shogo82148](https://togithub.com/shogo82148) in [https://github.com/goccy/go-yaml/pull/393](https://togithub.com/goccy/go-yaml/pull/393) #### New Contributors - [@​WillAbides](https://togithub.com/WillAbides) made their first contribution in [https://github.com/goccy/go-yaml/pull/370](https://togithub.com/goccy/go-yaml/pull/370) - [@​shogo82148](https://togithub.com/shogo82148) made their first contribution in [https://github.com/goccy/go-yaml/pull/391](https://togithub.com/goccy/go-yaml/pull/391) **Full Changelog**: goccy/go-yaml@v1.11.1...v1.11.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/anoriqq/qpm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #369
This resolves the quoted comments issue by updating the path filter account for quoted selectors.
Slightly related to this, I found that
Path.String()wasn't normalizing its output. I had to remove the*PathBuilderreceiver fromnormalizeSelectorName()to make this work.The changes to
context.goare not related to the rest of this PR. While tracing this I noticed thatcontext.modeisn't used, so I removed it.