-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape strings containing font glyphs (Nerd Font compatibility) #343
Conversation
@goccy are you still maintaining this? I don't mind using my fork, but it would be amazing to get a conversation started around this. |
192af9f
to
4befa91
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
=======================================
Coverage 76.02% 76.02%
=======================================
Files 13 13
Lines 4692 4692
=======================================
Hits 3567 3567
Misses 866 866
Partials 259 259 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution !! I've some commented.
1a4b52c
to
cd5b867
Compare
65c8752
to
6fdc187
Compare
@goccy only relevant changes remaining. And sorry it took me THIS long to address this again. Really bad behaviour.... |
6fdc187
to
37d351c
Compare
This fixes an issue with Nerd Font glyphs (and others, but this is my use-case) not being recognised resulting in a non-quoted string, which in YAML makes them literal text rather than icons. This breaks config exports and migrations for oh-my-posh.
Example:
Is encoded to YAML as:
But that should be:
The
isEmoticon
function is the same as the one we use for oh-my-posh which has worked without issues so far.