Trailing new lines are added to literal strings

[nervo]

Even if they are not part of a literal string, trailing newlines are systematically added to the string

foo: |
  bar


# ↑↑↑ Note the two newlines right after the literal string

In this siituation, the bar value will be "bar\n\n" instead of "bar\n".

Note that this also applies with strip sign |-

Here is a simple reproduction case:

package main

import (
	"fmt"
	goYaml "github.com/goccy/go-yaml"
)

func main() {
	yml := `
foo: |-
  bar


`
	var vmap[string]any
	goYaml.Unmarshal([]byte(yml), &v)

	fmt.Println(v["foo"])
	// -> "bar\n\n"
}

And a related playground: https://go.dev/play/p/XG6oCnbwwiz

• Go version: 1.21.2
• go-yaml's Version: v1.11.2

[nervo]

Partially fixed by #421 :)

Now, additional trailing lines only occurs without the strip (-) indicator.

@zoncoen may i ask you some help on this ?

[goccy]

@nervo github.com/go-yaml/yaml also interprets this as a single newline, and I believe interpreting it as one is correct according to the spec. Please provide a source that justifies interpreting it as two.

[nervo]

@goccy sorry, maybe there is a misunderstanding :)
In such a situation, according to the spec, there should be only one newline, exactly as you say.

The issue is that there is currently two new lines :)

[goccy]

@nervo I see, so unnecessary newline characters are being added. That does seem to be the case. Thank you.

[goccy]

@nervo I've fixed this problem with #507 . This was already reflected to master branch. Please confirm it 🙏