Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run yaml-test-suite on CI #465

Closed
mx-psi opened this issue Jul 16, 2024 · 1 comment
Closed

Run yaml-test-suite on CI #465

mx-psi opened this issue Jul 16, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request feature request

Comments

@mx-psi
Copy link

mx-psi commented Jul 16, 2024

Is your feature request related to a problem? Please describe.

Correctness is one of the most important priorities for a parsing library. As evidenced by issues like #460, #455, #407, #406 and #399 among others, this library has quite a few edge cases in which parsing does not work correctly (i.e. according to the YAML specificaiton). While this is not uncommon in YAML implementations, it anecdotically seems like go-yaml has more bugs than other libraries, or at least bugs in some more common cases.

Describe the solution you'd like

yaml/yaml-test-suite is a language agnostic test suite widely used for ensuring conformance. Adding this test suite on CI would greatly help in reducing the amount of bugs in this library. All tests that fail today could be skipped and tracked, and existing issues could be tied to failing tests in the test suite.

Describe alternatives you've considered

Do nothing?

Additional context

I was considering this library for adoption in the opentelemetry-collector repository, this is one of the blockers in my view.

@goccy goccy added the enhancement New feature or request label Nov 1, 2024
@goccy goccy self-assigned this Nov 15, 2024
This was referenced Nov 15, 2024
@goccy
Copy link
Owner

goccy commented Nov 26, 2024

Thank you for your reports !
I've already added yaml-test-suite in this repo.

@goccy goccy closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request
Projects
None yet
Development

No branches or pull requests

2 participants