support empty sequence value (#503)

goccy · Nov 3, 2024 · ab16112 · ab16112
1 parent 8f8d730
commit ab16112
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/parser/parser.go b/parser/parser.go
@@ -476,9 +476,11 @@ func (p *parser) parseSequenceEntry(ctx *context) (*ast.SequenceNode, error) {
 	curColumn := tk.Position.Column
 	for tk.Type == token.SequenceEntryType {
 		p.progress(1) // skip sequence token
+		entryTk := tk
 		tk = p.currentToken()
 		if tk == nil {
-			return nil, errors.ErrSyntax("empty sequence value", p.previousToken())
+			sequenceNode.Values = append(sequenceNode.Values, ast.Null(p.createNullToken(entryTk)))
+			break
 		}
 		var comment *ast.CommentGroupNode
 		if tk.Type == token.CommentType {

diff --git a/parser/parser_test.go b/parser/parser_test.go
@@ -93,6 +93,7 @@ func TestParser(t *testing.T) {
 		"value: >\n\n",
 		"value: >\nother:",
 		"value: >\n\nother:",
+		"a:\n-",
 	}
 	for _, src := range sources {
 		if _, err := parser.Parse(lexer.Tokenize(src), 0); err != nil {
@@ -974,19 +975,6 @@ a
 		},
 		{
 			`
-a:
-- b: c
-- `,
-			`
-[4:1] empty sequence value
-   2 | a:
-   3 | - b: c
->  4 | -
-       ^
-`,
-		},
-		{
-			`
 a: |invalidopt
   foo
 `,
@@ -1052,7 +1040,7 @@ a: -
 b: -
 `,
 			`
-[3:4] empty sequence value
+[3:4] block sequence entries are not allowed in this context
    2 | a: -
 >  3 | b: -
           ^

diff --git a/scanner/scanner.go b/scanner/scanner.go
@@ -802,7 +802,7 @@ func (s *Scanner) scanSequence(ctx *Context) bool {
 	}
 
 	nc := ctx.nextChar()
-	if nc != ' ' && !s.isNewLineChar(nc) {
+	if nc != 0 && nc != ' ' && !s.isNewLineChar(nc) {
 		return false
 	}