-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset runtime context options before releasing it back into pool #500
base: master
Are you sure you want to change the base?
Reset runtime context options before releasing it back into pool #500
Conversation
@goccy any chance you could look at the issue and PR? To me, it seems like a pretty straightforward fix. |
Sorry for the late reply, Please re-commit to run CI 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #500 +/- ##
==========================================
+ Coverage 76.78% 78.53% +1.74%
==========================================
Files 55 55
Lines 18922 16714 -2208
==========================================
- Hits 14529 13126 -1403
+ Misses 3759 2956 -803
+ Partials 634 632 -2 |
@goccy I see you released |
I saw this PR, but I cannot accept this implementation. |
Can you elaborate? Do you have suggestions on other approaches to address this bug? EDIT: I assume you're concerned about the allocation. How about the approach with setting the context to |
Any chance you had a look at the last commit @goccy? Or at least describe your concerns so I know how to address them. |
@goccy can you please respond? I am willing to do the work and fix the bug, but I can't do it without your cooperation. |
A friendly reminder that I'm waiting for a response. |
Bump. |
This PR makes sure
RuntimeContext
options are reset before the context is returned to the pool.It also adds a test case that fails without the change.
Fixes #499.