Handle formatOptions.useInt64Timestamp in tabledataListRequest
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goccy
approved these changes
Apr 6, 2024
|
It looks like the only conflict is in This problem caused about 2 days of extra work until I saw what was wrong so it would be great if we could merge and release a fix. ohaibbq PR is in a forked repo so I can't resolve the minor conflicts, I could fork-the-fork, resolve the conflict and create a new PR but that would be rude to Ohaibbq that did all the work. :) |
ohaibbq
force-pushed
the
dan/tabledata-list-int64
branch
from
974e0a7 to
55b8941
Compare
ohaibbq
force-pushed
the
dan/tabledata-list-int64
branch
from
c4c0f28 to
7753753
Compare
|
@goccy I've updated the dependencies and fixed a test failure |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #275